Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close test descriptor #335

Merged
merged 1 commit into from
Jan 1, 2022
Merged

close test descriptor #335

merged 1 commit into from
Jan 1, 2022

Conversation

peakle
Copy link
Contributor

@peakle peakle commented Jan 1, 2022

No description provided.

cristaloleg
cristaloleg approved these changes Jan 1, 2022
View reviewed changes
Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

analyzer/analyzer_test.go
defer func() {
mainFile.Close()
os.Remove(mainFile.Name())
}()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, we can rewrite it with https://pkg.go.dev/testing#T.TempDir and just drop folder after a test. However this can be less important than just close a file.

@quasilyte quasilyte merged commit 184fad6 into quasilyte:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peakle @cristaloleg @quasilyte